Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default seed_everything(workers=True) in the LightningCLI #7504

Merged
merged 4 commits into from
May 13, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 12, 2021

What does this PR do?

See title, also other minor changes:

  • Includes some docs improvements
  • Removes duplicate print statements (running trainer.test already prints the result)
  • Adds missing "#"s to the CHANGELOG

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added feature Is an improvement or enhancement argparse (removed) Related to argument parsing (argparse, Hydra, ...) labels May 12, 2021
@carmocca carmocca added this to the v1.4 milestone May 12, 2021
@carmocca carmocca self-assigned this May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #7504 (170ef58) into master (83283fd) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7504    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         199     199            
  Lines       13068   13068            
=======================================
- Hits        12026   11438   -588     
- Misses       1042    1630   +588     

@Borda Borda added the example label May 12, 2021
@Borda Borda enabled auto-merge (squash) May 12, 2021 14:54
@carmocca carmocca added the ready PRs ready to be merged label May 12, 2021
@carmocca carmocca requested a review from edenlightning as a code owner May 12, 2021 16:02
@carmocca carmocca disabled auto-merge May 12, 2021 21:49
@carmocca carmocca enabled auto-merge (squash) May 12, 2021 21:49
@carmocca carmocca merged commit a584196 into master May 13, 2021
@carmocca carmocca deleted the feat/cli-workers-true branch May 13, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argparse (removed) Related to argument parsing (argparse, Hydra, ...) example feature Is an improvement or enhancement has conflicts ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants