-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Support time-based checkpointing during training #7515
[feat] Support time-based checkpointing during training #7515
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7515 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 198 198
Lines 12912 12930 +18
=======================================
- Hits 11912 11368 -544
- Misses 1000 1562 +562 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
324687d
to
15e6b0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth adding a note in the case the user wants to do multiple stuff at the same time
.. note:
If you want a checkpoint at both every N hours and every M train batches or val epochs then multiple ``ModelCheckpoint`` should be created.
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
15e6b0a
to
51ac2ed
Compare
What does this PR do?
Fixes #6286
To discuss: The PR currently enforces each trigger (
every_n_train_steps
,train_time_interval
,every_n_val_epochs
) to be mutually exclusive. This means if someone wants to checkpoint every N hours and every M train batches, they'd need to create two callbacks.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃