-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MANIFEST.in and setup.py clean-up #7614
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7614 +/- ##
========================================
- Coverage 92% 92% -0%
========================================
Files 217 198 -19
Lines 14258 12930 -1328
========================================
- Hits 13161 11914 -1247
+ Misses 1097 1016 -81 |
c5281a3
to
692c233
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls make the benchmark move to test in separate PR, as it does not have any connection to Manifest/setup cleaning
What does this PR do?
python setup.py bdist_wheel
)python setup.py sdist
)check-manifest
use as it contradicts the output ofbdist_wheel
:Credit to @flying-sheep for finding the solution in #7596
Closes #7596
Fixes #10335
Resources:
Manually tested that everything is correctly included/excluded.
Part of https://github.com/PyTorchLightning/internal-dev/issues/132
Before submitting
PR review
cc @Borda @justusschock @awaelchli @akihironitta