Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Scheduler monitor for manual optimization #7643

Merged
merged 33 commits into from
Jul 27, 2021
Merged

Bugfix: Scheduler monitor for manual optimization #7643

merged 33 commits into from
Jul 27, 2021

Conversation

maxoppelt
Copy link
Contributor

@maxoppelt maxoppelt commented May 21, 2021

What does this PR do?

Fixes #6567

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

docs/source/common/optimizers.rst Outdated Show resolved Hide resolved
docs/source/common/optimizers.rst Outdated Show resolved Hide resolved
docs/source/common/optimizers.rst Outdated Show resolved Hide resolved
pytorch_lightning/trainer/optimizers.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/optimizers.py Outdated Show resolved Hide resolved
maxoppelt and others added 4 commits May 21, 2021 23:35
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@pep8speaks
Copy link

pep8speaks commented May 21, 2021

Hello @maxoppelt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-27 09:37:25 UTC

@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #7643 (522408f) into master (eaa16c7) will increase coverage by 0%.
The diff coverage is 96%.

@@          Coverage Diff           @@
##           master   #7643   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files         218     218           
  Lines       14405   14409    +4     
======================================
+ Hits        12705   12710    +5     
+ Misses       1700    1699    -1     

@carmocca carmocca added the bug Something isn't working label May 24, 2021
@carmocca carmocca added this to the v1.3.x milestone May 24, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test and update the CHANGELOG.md file?

docs/source/common/optimizers.rst Outdated Show resolved Hide resolved
Fixed package pytorch name.

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@Borda Borda added the waiting on author Waiting on user action, correction, or update label May 26, 2021
@Borda Borda added this to the v1.4 milestone Jul 6, 2021
@edenlightning edenlightning modified the milestones: v1.4, v1.3.x Jul 6, 2021
@edenlightning edenlightning modified the milestones: v1.3.x, v1.4 Jul 21, 2021
@kaushikb11 kaushikb11 self-assigned this Jul 26, 2021
@mergify mergify bot removed the has conflicts label Jul 27, 2021
Co-authored-by: thomas chaton <thomas@grid.ai>
@kaushikb11 kaushikb11 removed the waiting on author Waiting on user action, correction, or update label Jul 27, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have tests for verification that all the raised exceptions are correct?

docs/source/common/optimizers.rst Show resolved Hide resolved
pytorch_lightning/trainer/optimizers.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Jul 27, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) July 27, 2021 09:42
@kaushikb11 kaushikb11 merged commit d90cb7f into Lightning-AI:master Jul 27, 2021
@maxoppelt maxoppelt deleted the bugfix/scheduler_manual_optimization branch October 25, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.