-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Scheduler monitor for manual optimization #7643
Bugfix: Scheduler monitor for manual optimization #7643
Conversation
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Hello @maxoppelt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-27 09:37:25 UTC |
Codecov Report
@@ Coverage Diff @@
## master #7643 +/- ##
======================================
Coverage 88% 88%
======================================
Files 218 218
Lines 14405 14409 +4
======================================
+ Hits 12705 12710 +5
+ Misses 1700 1699 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test and update the CHANGELOG.md file?
Fixed package pytorch name. Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
… metric after every epoch.
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
for more information, see https://pre-commit.ci
….com/maxoppelt/pytorch-lightning into bugfix/scheduler_manual_optimization
Co-authored-by: thomas chaton <thomas@grid.ai>
….com/maxoppelt/pytorch-lightning into bugfix/scheduler_manual_optimization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have tests for verification that all the raised exceptions are correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
….com/maxoppelt/pytorch-lightning into bugfix/scheduler_manual_optimization
What does this PR do?
Fixes #6567
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃