Remove ProfilerConnector class #7654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
requested review from
awaelchli,
Borda,
carmocca,
SeanNaren,
tchaton and
williamFalcon
as code owners
|
Hello @ananthsub! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-22 16:01:16 UTC |
Codecov Report
@@ Coverage Diff @@
## master #7654 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 198 197 -1
Lines 12835 12825 -10
=======================================
- Hits 11873 11279 -594
- Misses 962 1546 +584 |
ananthsub
changed the title
ananthsub
commented
May 22, 2021
Comment on lines
+1266
to
+1279
| if isinstance(profiler, str): | ||
| PROFILERS = { | ||
| "simple": SimpleProfiler, | ||
| "advanced": AdvancedProfiler, | ||
| "pytorch": PyTorchProfiler, | ||
| } | ||
| profiler = profiler.lower() | ||
| if profiler not in PROFILERS: | ||
| raise MisconfigurationException( | ||
| "When passing string value for the `profiler` parameter of `Trainer`," | ||
| f" it can only be one of {list(PROFILERS.keys())}" | ||
| ) | ||
| profiler_class = PROFILERS[profiler] | ||
| profiler = profiler_class() |
There was a problem hiding this comment.
this could be formalized in a profiler registry later
carmocca
approved these changes
May 24, 2021
awaelchli
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #7493
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃