Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning when Trainer(log_every_n_steps) not well chosen #7734

Merged
merged 9 commits into from
Jun 7, 2021

Conversation

awaelchli
Copy link
Contributor

What does this PR do?

Fixes #7705

No training logs are shown if the logging interval is smaller than the dataloader size. We show a warning that the value for
log_every_n_steps can be decreased if desired.

Printing the warning in the reset_dataloader() method is maybe not the best but could not find a better place. Suggestion welcome.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added feature Is an improvement or enhancement logger Related to the Loggers labels May 27, 2021
@awaelchli awaelchli added this to the v1.4 milestone May 27, 2021
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #7734 (44f6243) into master (41be61c) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #7734   +/-   ##
======================================
- Coverage      93%     92%   -0%     
======================================
  Files         202     202           
  Lines       13121   13123    +2     
======================================
- Hits        12154   12118   -36     
- Misses        967    1005   +38     

@carmocca
Copy link
Contributor

Should we show the same warning for val batches?

@awaelchli
Copy link
Contributor Author

@carmocca
not necessary, logging frequency has no influence there, since all logs from evaluation are aggregated into a single logging step.

@justusschock justusschock enabled auto-merge (squash) May 31, 2021 08:12
@mergify mergify bot removed the has conflicts label May 31, 2021
@SkafteNicki SkafteNicki added the ready PRs ready to be merged label May 31, 2021
@mergify mergify bot added the has conflicts label Jun 7, 2021
@mergify mergify bot removed the has conflicts label Jun 7, 2021
@justusschock justusschock merged commit 20f37b8 into master Jun 7, 2021
@justusschock justusschock deleted the feature/warn-log-interval branch June 7, 2021 12:40
Borda pushed a commit that referenced this pull request Jun 8, 2021
* add warning

* update changelog

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* logger check

* add docstring for test

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging inconsistencies while using Tensorboard
4 participants