-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add warning when Trainer(log_every_n_steps) not well chosen #7734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
feature
Is an improvement or enhancement
logger
Related to the Loggers
labels
May 27, 2021
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
May 27, 2021 08:50
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #7734 +/- ##
======================================
- Coverage 93% 92% -0%
======================================
Files 202 202
Lines 13121 13123 +2
======================================
- Hits 12154 12118 -36
- Misses 967 1005 +38 |
justusschock
approved these changes
May 27, 2021
…feature/warn-log-interval
carmocca
approved these changes
May 27, 2021
Should we show the same warning for val batches? |
@carmocca |
SkafteNicki
approved these changes
May 31, 2021
Borda
pushed a commit
that referenced
this pull request
Jun 8, 2021
* add warning * update changelog * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * logger check * add docstring for test Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #7705
No training logs are shown if the logging interval is smaller than the dataloader size. We show a warning that the value for
log_every_n_steps
can be decreased if desired.Printing the warning in the
reset_dataloader()
method is maybe not the best but could not find a better place. Suggestion welcome.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃