-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid adding None
loss values in training_epoch_end
#7772
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
awaelchli,
Borda,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
May 31, 2021 02:40
Codecov Report
@@ Coverage Diff @@
## master #7772 +/- ##
======================================
- Coverage 92% 92% -0%
======================================
Files 199 199
Lines 12986 12987 +1
======================================
- Hits 11994 11982 -12
- Misses 992 1005 +13 |
carmocca
changed the title
Avoid adding None loss keys on train epoch end
Avoid adding May 31, 2021
None
loss values in training_epoch_end
carmocca
commented
May 31, 2021
justusschock
approved these changes
May 31, 2021
SkafteNicki
approved these changes
May 31, 2021
awaelchli
reviewed
May 31, 2021
awaelchli
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In manual optimization, users are not forced to return a loss in their
training_step
.However, this meant that a
None
loss was getting added intraining_epoch_end
.Also reduced code duplication in the tests.
Part of #7631
Even though this is a bug-fix, it doesn't need to go into 1.3.x as no user reported this.
Before submitting
PR review