-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Move each profiler to its own file + Add missing PyTorchProfiler to the doc #7822
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7822 +/- ##
======================================
- Coverage 93% 92% -0%
======================================
Files 199 202 +3
Lines 13016 13039 +23
======================================
- Hits 12051 12036 -15
- Misses 965 1003 +38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imports may brake for some people who do not import at top level from init file
Hey @awaelchli. Added a depreciation call. Best, |
Is it rename files or adding new code, from the PR diff it is not clear... |
This PR extracts each profiler from profilers.py and move it to simple.py, advanced.py, etc.. Best, |
What does this PR do?
Fixes #7806
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃