Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Wandb entity attribute #783

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Conversation

calclavia
Copy link
Contributor

Minor change to allow config Wandb entity parameter

@Borda
Copy link
Member

Borda commented Feb 3, 2020

@calclavia could you write more about the change, what is the use-case?

@Borda Borda added feature Is an improvement or enhancement information needed labels Feb 3, 2020
@Borda Borda added this to the 0.6.1 milestone Feb 3, 2020
@@ -33,7 +33,7 @@ class WandbLogger(LightningLoggerBase):
"""

def __init__(self, name=None, save_dir=None, offline=False, id=None, anonymous=False,
version=None, project=None, tags=None, experiment=None):
version=None, project=None, tags=None, experiment=None, entity=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls, write docstring and describe usage of particular parameters...

@williamFalcon williamFalcon merged commit 57074b3 into Lightning-AI:master Feb 6, 2020
@Borda
Copy link
Member

Borda commented Feb 6, 2020

So what is the entity? @calclavia

@calclavia
Copy link
Contributor Author

See https://docs.wandb.com/library/python/init
It's the team of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants