Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tpu_spawn_debug to plugin registry #7933

Merged
merged 4 commits into from
Jun 15, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Add tpu_spawn_debug to plugin registry

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #7933 (b0e8537) into master (92024df) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7933    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         207     207            
  Lines       13365   13368     +3     
=======================================
- Hits        12235   11603   -632     
- Misses       1130    1765   +635     

tests/models/test_tpu.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added this to the v1.4 milestone Jun 11, 2021
tests/models/test_tpu.py Outdated Show resolved Hide resolved
@kaushikb11 kaushikb11 enabled auto-merge (squash) June 14, 2021 09:08
@kaushikb11 kaushikb11 force-pushed the add/tpu_spawn_debug branch from 0f9319f to 7aba9d5 Compare June 15, 2021 20:42
@kaushikb11 kaushikb11 force-pushed the add/tpu_spawn_debug branch from 7aba9d5 to b0e8537 Compare June 15, 2021 22:02
@kaushikb11 kaushikb11 merged commit 78a14a3 into Lightning-AI:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants