Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add Logging Restoration on Failure 2/2 #7966

Merged
merged 108 commits into from
Jun 25, 2021
Merged

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jun 14, 2021

What does this PR do?

Improve support for state restoration of results

Requires TM RC.

Tracking Issue: #7898
Follow up to #7948

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@tchaton tchaton added this to the v1.4 milestone Jun 14, 2021
@tchaton tchaton self-assigned this Jun 14, 2021
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #7966 (189f0ad) into master (55a90af) will decrease coverage by 0%.
The diff coverage is 93%.

@@          Coverage Diff           @@
##           master   #7966   +/-   ##
======================================
- Coverage      93%     92%   -0%     
======================================
  Files         211     211           
  Lines       13416   13448   +32     
======================================
- Hits        12447   12437   -10     
- Misses        969    1011   +42     

@tchaton tchaton changed the title [feat] Add restore result collection on failure [feat] Add Logging Restarting on Failure 2/2 Jun 14, 2021
@tchaton tchaton marked this pull request as ready for review June 14, 2021 10:41
@carmocca carmocca added the feature Is an improvement or enhancement label Jun 25, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic!

@carmocca carmocca disabled auto-merge June 25, 2021 18:55
@carmocca carmocca enabled auto-merge (squash) June 25, 2021 18:57
@carmocca carmocca added the ready PRs ready to be merged label Jun 25, 2021
@carmocca carmocca merged commit 24db914 into master Jun 25, 2021
@carmocca carmocca deleted the fault_tolerant_log_2/n branch June 25, 2021 19:16
return partial(self.fn, reduce_op=self.op, group=self.group) if self.should else self.no_op
return (
partial(self.fn, reduce_op=self.op, group=self.group)
if self.should and not self.rank_zero_only else self.no_op
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazhang as an FYI where the self.rank_zero_only check was introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion feature Is an improvement or enhancement logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants