[fix] Enable manual optimization DeepSpeed #7970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren and
williamFalcon
as code owners
|
Hello @tchaton! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-06-16 09:02:29 UTC |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #7970 +/- ##
======================================
- Coverage 92% 91% -0%
======================================
Files 207 207
Lines 13378 13380 +2
======================================
- Hits 12248 12214 -34
- Misses 1130 1166 +36 |
SeanNaren
reviewed
Jun 14, 2021
carmocca
reviewed
Jun 14, 2021
|
Let's get #7234 merged, then I'll rebase this PR and address comments for thomas! |
# Conflicts: # dockers/base-cuda/Dockerfile # pytorch_lightning/plugins/training_type/deepspeed.py
added 2 commits
June 15, 2021 10:58
SeanNaren
changed the title
|
The test failing is associated to #7790 so should be good to go |
|
Cherry picking this for 1.3.x will be difficult as it relies on the later DeepSpeed Infinity API, so we'll wait for 1.4. |
carmocca
approved these changes
Jun 15, 2021
awaelchli
reviewed
Jun 15, 2021
SeanNaren
approved these changes
Jun 15, 2021
awaelchli
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables support for manual optimization for DeepSpeed.
However, DeepSpeed only supports 1 optimizer.
Fixes #7957 #6503
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃