Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add tracking on new TrainLoop #7976

Closed
wants to merge 579 commits into from
Closed

[feat] Add tracking on new TrainLoop #7976

wants to merge 579 commits into from

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jun 14, 2021

What does this PR do?

Progress guide: https://docs.google.com/document/d/1U73b4uFML2MNdObh6MVsBpFDrgLUOU2Sd_x0_DVk-Bo/edit?usp=sharing

This PR adds tracking on the new FitLoop.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton changed the title [feat] Add tracking on new TrainLoop [wip] [feat] Add tracking on new TrainLoop Jun 17, 2021
pytorch_lightning/loops/fit_loop.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added the ready PRs ready to be merged label Jun 18, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting to let me review

pytorch_lightning/trainer/progress.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Jun 18, 2021
@carmocca carmocca assigned carmocca and unassigned tchaton Jun 18, 2021
@carmocca carmocca removed the ready PRs ready to be merged label Jun 21, 2021
@carmocca carmocca marked this pull request as draft June 21, 2021 16:44
@tchaton tchaton marked this pull request as ready for review June 25, 2021 08:42
@tchaton tchaton mentioned this pull request Jun 25, 2021
11 tasks
@mergify mergify bot removed the has conflicts label Jun 29, 2021
@carmocca carmocca closed this Jun 29, 2021
@carmocca carmocca deleted the progress_tracking branch June 29, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants