-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Named Parameter Groups in LearningRateMonitor
#7987
[feat] Named Parameter Groups in LearningRateMonitor
#7987
Conversation
Hello @AffineParameter! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-06-16 18:39:55 UTC |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #7987 +/- ##
=======================================
- Coverage 92% 87% -5%
=======================================
Files 203 207 +4
Lines 13157 13389 +232
=======================================
- Hits 12043 11617 -426
- Misses 1114 1772 +658 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
LearningRateMonitor
LearningRateMonitor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Happy to update the CHANGELOG, provided I can get a milestone to target. This should tie a bow on things? Thanks for the quick reviews! |
@AffineParameter (love the name btw) <3 |
PR Digression: The contribution process (docs, workflow, reviews, etc.) have been really easy to work with! I am sure getting to this point hasn't been easy, but the effort and intentionality really shows. 🎩 's to all those responsible! :) |
This is the last time I draw more attention to my already approved PR's by complementing the maintainers... 🤣 But seriously, I'll respond when I get the chance, and thanks for the great comments & suggestions! |
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Hey @AffineParameter, we definitely appreciated your mindset and contribution ! Best, |
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Head branch was pushed to by a user without write access
What does this PR do?
This PR allows the
LearningRateMonitor
callback to log the actual parameter group names, if they exist. It should fallback to prior behavior in the event that the parameter group names do not exist.Fixes #7981
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃