-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate returning extras with grads #7994
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7994 +/- ##
======================================
- Coverage 92% 91% -0%
======================================
Files 207 207
Lines 13368 13383 +15
======================================
- Hits 12238 12217 -21
- Misses 1130 1166 +36 |
pytorch_lightning/trainer/connectors/logger_connector/result.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
you have some commented lines which would need removal :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
Fixes #7882 (comment)
cc: @kandluis @simran2905
Before submitting
PR review