Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DDPPlugin.task_idx #8203

Merged
merged 4 commits into from
Jun 29, 2021
Merged

Deprecate DDPPlugin.task_idx #8203

merged 4 commits into from
Jun 29, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Legacy attribute

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #8203 (3067860) into master (47c7654) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8203   +/-   ##
======================================
- Coverage      93%     92%   -0%     
======================================
  Files         212     212           
  Lines       13588   13595    +7     
======================================
- Hits        12626   12566   -60     
- Misses        962    1029   +67     

@carmocca carmocca added the ready PRs ready to be merged label Jun 29, 2021
@carmocca carmocca merged commit 2e537b7 into master Jun 29, 2021
@carmocca carmocca deleted the feat/deprecate-task-idx branch June 29, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants