Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix best score on wrong device in EarlyStopping callback #8295

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 5, 2021

What does this PR do?

Fixes #8267

The problematic conversion was introduced in #7959 to fix an issue on TPU, but it can happen now that the current score and the best score are on different devices.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli changed the title fix device fix best score on wrong device in EarlyStopping callback Jul 5, 2021
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #8295 (358e4d3) into master (7ddcdb2) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8295   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         213     213           
  Lines       13804   13804           
======================================
- Hits        12749   12736   -13     
- Misses       1055    1068   +13     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton marked this pull request as ready for review July 6, 2021 07:46
@kaushikb11 kaushikb11 enabled auto-merge (squash) July 6, 2021 07:50
@kaushikb11 kaushikb11 added the bug Something isn't working label Jul 6, 2021
@kaushikb11 kaushikb11 added this to the v1.3.x milestone Jul 6, 2021
@awaelchli awaelchli disabled auto-merge July 6, 2021 08:34
@awaelchli awaelchli enabled auto-merge (squash) July 6, 2021 08:35
@awaelchli awaelchli merged commit 1e1d182 into master Jul 6, 2021
@awaelchli awaelchli deleted the bugfix/es-device branch July 6, 2021 08:59
@Borda
Copy link
Member

Borda commented Jul 6, 2021

chnagelog?

@awaelchli
Copy link
Contributor Author

awaelchli commented Jul 6, 2021

@Borda the chnagelog was already added in #7959. This here is just a slight improvement of that same fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants