Add progress tracking on Loops - 2/n #8362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #8362 +/- ##
======================================
- Coverage 93% 92% -0%
======================================
Files 216 216
Lines 14109 14093 -16
======================================
- Hits 13083 13000 -83
- Misses 1026 1093 +67 |
carmocca
force-pushed
the
add_progress_tracking_on_loops
branch
from
994fd37 to
e550e6d
Compare
carmocca
reviewed
Jul 15, 2021
carmocca
approved these changes
Jul 16, 2021
SeanNaren
reviewed
Jul 18, 2021
SeanNaren
approved these changes
Jul 18, 2021
justusschock
approved these changes
Jul 19, 2021
| @@ -1259,3 +1261,10 @@ def _log_device_info(self) -> None: | |||
| "IPU available but not used. Set the `ipus` flag in your trainer" | |||
| " `Trainer(ipus=8)` or script `--ipus=8`." | |||
| ) | |||
|
|
|||
| def _on_expection(self): | |||
There was a problem hiding this comment.
I have a question about this function - is there a reason it is a function instead of a few lines in the exception handling? This function is only called once
This function seems a bit like a callback, but that's not what it is right? Still learning and understanding
There was a problem hiding this comment.
It was just meant as a stub for further improvements:
We can think about the fault-tolerant checkpoint design in a later PR.
It's entirely fine to change it - although it wouldn't be a callback as it only needs to run on one hook: on_exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR build on top of #8334. Merge in order.
This PR adds progress tracking to Fit / Evaluation / Predict loops and ensures the correct progress state.
Fixes #6429
Does your PR introduce any breaking changes? If yes, please list them.
No
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃