Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable manual optimization for TPUs #8458

Merged
merged 12 commits into from
Jul 22, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Jul 19, 2021

What does this PR do?

Fixes #6503

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
  • Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #8458 (4362af2) into master (35a6a6c) will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master   #8458   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files         218     218           
  Lines       14397   14397           
======================================
  Hits        12676   12676           
  Misses       1721    1721           

@pep8speaks
Copy link

pep8speaks commented Jul 21, 2021

Hello @kaushikb11! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-21 12:17:29 UTC

@kaushikb11 kaushikb11 self-assigned this Jul 21, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review July 21, 2021 07:17
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot removed the has conflicts label Jul 21, 2021
@awaelchli awaelchli added bug Something isn't working accelerator: tpu Tensor Processing Unit labels Jul 21, 2021
@awaelchli awaelchli added this to the v1.3.x milestone Jul 21, 2021
@mergify mergify bot removed the has conflicts label Jul 21, 2021
@edenlightning edenlightning modified the milestones: v1.3.x, v1.4 Jul 21, 2021
@mergify mergify bot added the ready PRs ready to be merged label Jul 22, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) July 22, 2021 09:32
@kaushikb11 kaushikb11 merged commit 5452590 into Lightning-AI:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit bug Something isn't working ready PRs ready to be merged
Projects
None yet
7 participants