Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove DeepSpeed Plugin FP16 exception #8462

Merged
merged 9 commits into from
Jul 19, 2021
Merged

[Fix] Remove DeepSpeed Plugin FP16 exception #8462

merged 9 commits into from
Jul 19, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jul 19, 2021

What does this PR do?

Removes an exception thrown where the precision isn't set to 16, as this is now supported in Deepspeed.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
  • Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added bug Something isn't working 3rd party Related to a 3rd-party labels Jul 19, 2021
@SeanNaren SeanNaren added this to the v1.4 milestone Jul 19, 2021
@SeanNaren SeanNaren self-assigned this Jul 19, 2021
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #8462 (92def46) into master (257fabd) will increase coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8462    +/-   ##
=======================================
  Coverage      92%     92%            
=======================================
  Files         217     217            
  Lines       14097   14221   +124     
=======================================
+ Hits        13004   13126   +122     
- Misses       1093    1095     +2     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

tests/plugins/test_deepspeed_plugin.py Outdated Show resolved Hide resolved
@SeanNaren SeanNaren enabled auto-merge (squash) July 19, 2021 10:32
@SeanNaren SeanNaren merged commit 06ac7d9 into master Jul 19, 2021
@SeanNaren SeanNaren deleted the feat/ds_fp32 branch July 19, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants