Always use trainer.call_hook

[carmocca]

What does this PR do?

Always try to use trainer.call_hook to call hooks as we need it to set the _current_fx_name attribute in the LightningModule which is required for logging.

Since call_hook also calls any trainer and accelerator methods with the same name, we need to skip them for setup and teardown.

A test is added which tries to self.log() in all LightningModule and Callback hooks to assert that MisconfigurationException is raised.

Part of #7898

Follow-ups

• The new test could assert the final logged values.
• We should refactor call_hook. The current pattern of always calling the accelerator and trainer hooks of the same name is dangerous. Also, we want the users to interact with it after loop customization. [RFC] Re-design call_hook interface #8506

Does your PR introduce any breaking changes ? If yes, please list them.

None intended

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• [n/a] Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
• Did you list all the breaking changes introduced by this pull request?

PR review

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

[codecov]

Codecov Report

Merging #8498 (e97c094) into master (d0efb55) will decrease coverage by 4%.
The diff coverage is 98%.

@@           Coverage Diff           @@
##           master   #8498    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         172     172            
  Lines       14093   14092     -1     
=======================================
- Hits        13095   12514   -581     
- Misses        998    1578   +580     

[Borda]

this will disable usage tracing in IDE, right?

[carmocca]

this will disable usage tracing in IDE, right?

Yes, this was already the case. Most hooks are already using call_hook

If you have ideas about how to improve that, you can comment in #8506

[tchaton]

LGTM ! Great work !