Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outputs in on_train_epoch_end hooks #8587

Merged
merged 5 commits into from
Jul 28, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Follow-up to the deprecation in #7339

Does your PR introduce any breaking changes? If yes, please list them.

The removal of outputs argument after the deprecation

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added refactor breaking change Includes a breaking change labels Jul 27, 2021
@carmocca carmocca added this to the v1.5 milestone Jul 27, 2021
@carmocca carmocca self-assigned this Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #8587 (b6569fc) into master (6b47cbe) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8587    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         218     218            
  Lines       14398   14364    -34     
=======================================
- Hits        13296   12669   -627     
- Misses       1102    1695   +593     

@mergify mergify bot added the ready PRs ready to be merged label Jul 28, 2021
@carmocca carmocca enabled auto-merge (squash) July 28, 2021 16:03
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit 47c47fa into master Jul 28, 2021
@carmocca carmocca deleted the deprecation/remove-outputs-from-hook branch July 28, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants