Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference issues during epoch end result collection #8621

Merged
merged 5 commits into from
Jul 30, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jul 29, 2021

What does this PR do?

Fixes 2 issues:

  • The _process_training_step_output method was modifying the training step output, which could be problematic if the user saved it in training_batch_end.
  • The _prepare_outputs function was modifying the current ResultCollection.extra dictionary.
  • The _track_epoch_end_reduce_metrics method wasn't collapsing the sequence if only one element when it was a ResultCollection. This was probably a remnant from the Result/dict return days.

The added test covers both

Found while debugging #8613

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added the bug Something isn't working label Jul 29, 2021
@carmocca carmocca added this to the v1.4.x milestone Jul 29, 2021
@carmocca carmocca self-assigned this Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #8621 (df11b49) into master (c99e2fe) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8621   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         168     168           
  Lines       13951   13951           
======================================
+ Hits        12909   12911    +2     
+ Misses       1042    1040    -2     

@carmocca carmocca changed the title Fix references for ResultCollection.extra Fix reference issues during epoch end result collection Jul 29, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Jul 30, 2021
@carmocca carmocca enabled auto-merge (squash) July 30, 2021 10:48
@carmocca carmocca merged commit 5789e9f into master Jul 30, 2021
@carmocca carmocca deleted the bugfix/result-collection-extra branch July 30, 2021 12:16
awaelchli added a commit that referenced this pull request Jul 31, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
awaelchli added a commit that referenced this pull request Jul 31, 2021
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
awaelchli added a commit that referenced this pull request Jul 31, 2021
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
awaelchli added a commit that referenced this pull request Aug 3, 2021
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
lexierule pushed a commit that referenced this pull request Aug 3, 2021
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants