Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change backbone to self #8762

Merged
merged 1 commit into from
Aug 6, 2021
Merged

change backbone to self #8762

merged 1 commit into from
Aug 6, 2021

Conversation

HansolEom
Copy link
Contributor

No need to use backbone. Calling self proceeds forward.

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

No need to use backbone. Calling self proceeds forward.
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Borda Borda added feature Is an improvement or enhancement example labels Aug 6, 2021
@mergify mergify bot added the ready PRs ready to be merged label Aug 6, 2021
@Borda Borda enabled auto-merge (squash) August 6, 2021 09:20
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #8762 (e9e09a6) into master (8473cf4) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8762    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         169     169            
  Lines       14072   14072            
=======================================
- Hits        13041   12462   -579     
- Misses       1031    1610   +579     

@Borda Borda merged commit 69f287e into Lightning-AI:master Aug 6, 2021
@SeanNaren SeanNaren added this to the v1.5 milestone Aug 10, 2021
four4fish pushed a commit to four4fish/pytorch-lightning that referenced this pull request Aug 16, 2021
No need to use backbone. Calling self proceeds forward.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants