-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow exporting to onnx when input is tuple #8800
Allow exporting to onnx when input is tuple #8800
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8800 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 169 169
Lines 14078 14080 +2
=======================================
- Hits 13052 12476 -576
- Misses 1026 1604 +578 |
072eb5b
to
8f3c73a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mind adding a changelog entry too? :)
8f3c73a
to
10bb958
Compare
Thanks, updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
Per docs for example_input_array the model input can be Tensor, Tuple or Dict.
When input is tuple, it's forwarded as tuple.
Fixes #8799
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃