Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to DistributedDataParallel from parallel plugin teardown #8943

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Aug 16, 2021

What does this PR do?

Parallel plugin should be generic and self-contained. Move reference to DistributedDataParallel from parallel teardown()

Subtask 1 for "remove reference to DistributedDataParallel from parallel plugin"

Tests:
python -m pytest -v tests/plugins/test_ddp_spawn_plugin.py passed
dev python -m pytest -v tests/plugins/test_ddp_plugin.py passed

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #8943 (59592cb) into master (53885af) will decrease coverage by 4%.
The diff coverage is 58%.

❗ Current head 59592cb differs from pull request most recent head ca53ba0. Consider uploading reports for the commit ca53ba0 to get more accurate results

@@           Coverage Diff           @@
##           master   #8943    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         176     176            
  Lines       14790   14673   -117     
=======================================
- Hits        13638   12894   -744     
- Misses       1152    1779   +627     

@awaelchli awaelchli added the feature Is an improvement or enhancement label Aug 17, 2021
@awaelchli awaelchli added this to the v1.5 milestone Aug 17, 2021
@four4fish four4fish marked this pull request as draft August 19, 2021 21:19
@four4fish four4fish changed the title Clean up wrapper for a few training type plugins Remove reference to DistributedDataParallel from parallel plugin teardown() Aug 19, 2021
@ananthsub ananthsub changed the title Remove reference to DistributedDataParallel from parallel plugin teardown() Remove reference to DistributedDataParallel from parallel plugin teardown Aug 19, 2021
@ananthsub ananthsub added the distributed Generic distributed-related topic label Aug 19, 2021
@four4fish four4fish force-pushed the siyu-dev branch 2 times, most recently from fbd5a83 to a6c21b6 Compare August 20, 2021 01:36
@mergify mergify bot added the ready PRs ready to be merged label Aug 22, 2021
tests/plugins/test_ddp_spawn_plugin.py Outdated Show resolved Hide resolved
tests/plugins/test_ddp_spawn_plugin.py Outdated Show resolved Hide resolved
tests/plugins/test_ddp_spawn_plugin.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! But I believe we already have test for this.

tests/plugins/test_ddp_plugin.py Outdated Show resolved Hide resolved
tests/plugins/test_ddp_spawn_plugin.py Outdated Show resolved Hide resolved
tests/plugins/test_ddp_spawn_plugin.py Outdated Show resolved Hide resolved
@Borda Borda requested a review from awaelchli August 24, 2021 07:03
@four4fish
Copy link
Contributor Author

Remove the unit test as it's already covered. Will add more unit test if it's needed after #9096

@mergify mergify bot removed the has conflicts label Aug 27, 2021
@ananthsub ananthsub merged commit b497fb8 into Lightning-AI:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Generic distributed-related topic feature Is an improvement or enhancement ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants