-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ci tpu test from github workflows #8965
Remove ci tpu test from github workflows #8965
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8965 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 176 176
Lines 14402 14411 +9
=======================================
- Hits 13343 12772 -571
- Misses 1059 1639 +580 |
n00b question: do you know why it was added to GitHub workflows? which tests are supposed to run on CircleCI vs GitHub workflows? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then you need to run them also on master and edit badge in Readme...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README looks good: https://github.com/kaushikb11/pytorch-lightning/tree/remove/ci_test_tpu
What is the status of this pr? |
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
What does this PR do?
As we run TPU tests on CircleCI
Fixes #8961
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃