Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ci tpu test from github workflows #8965

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

As we run TPU tests on CircleCI
Fixes #8961

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added the ci Continuous Integration label Aug 18, 2021
@kaushikb11 kaushikb11 self-assigned this Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #8965 (b1cbe73) into master (522df2b) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8965    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         176     176            
  Lines       14402   14411     +9     
=======================================
- Hits        13343   12772   -571     
- Misses       1059    1639   +580     

@ananthsub
Copy link
Contributor

n00b question: do you know why it was added to GitHub workflows? which tests are supposed to run on CircleCI vs GitHub workflows?

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then you need to run them also on master and edit badge in Readme...

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniellepintz
Copy link
Contributor

What is the status of this pr?

@carmocca carmocca requested a review from Borda August 26, 2021 00:42
@mergify mergify bot added the ready PRs ready to be merged label Aug 26, 2021
@kaushikb11 kaushikb11 merged commit 5c2b7ca into Lightning-AI:master Aug 26, 2021
@kaushikb11 kaushikb11 deleted the remove/ci_test_tpu branch August 26, 2021 09:41
ethanwharris pushed a commit that referenced this pull request Aug 31, 2021
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
@ethanwharris ethanwharris added this to the v1.4.x milestone Aug 31, 2021
lexierule pushed a commit that referenced this pull request Sep 1, 2021
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TPU tests failing in CI
7 participants