Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Trainer.call_hook re-design #9029

Closed
wants to merge 5 commits into from
Closed

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Fixes #8506

The hooks order and number have been kept.

Does your PR introduce any breaking changes? If yes, please list them.

Breaking for existingcall_hook users.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.5 milestone Aug 21, 2021
@carmocca carmocca self-assigned this Aug 21, 2021
@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #9029 (b947f07) into master (92e4979) will decrease coverage by 49%.
The diff coverage is 3%.

@@           Coverage Diff            @@
##           master   #9029     +/-   ##
========================================
- Coverage      93%     43%    -49%     
========================================
  Files         175     175             
  Lines       14400   14436     +36     
========================================
- Hits        13341    6269   -7072     
- Misses       1059    8167   +7108     

@carmocca carmocca modified the milestones: v1.5, v1.6 Oct 28, 2021
@carmocca carmocca closed this Nov 16, 2021
@carmocca carmocca deleted the refactor/call-hook-redesign branch November 16, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Re-design call_hook interface
2 participants