Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unskip log_dir tests #9105

Merged
merged 1 commit into from
Aug 25, 2021
Merged

unskip log_dir tests #9105

merged 1 commit into from
Aug 25, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 25, 2021

What does this PR do?

You need to name the file test_* for pytest to detect it as a file to run for tests.
Introduced in #8187

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added the ci Continuous Integration label Aug 25, 2021
@awaelchli awaelchli added this to the v1.5 milestone Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #9105 (805aff5) into master (bf8c1fd) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #9105    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         176     176            
  Lines       14663   14663            
=======================================
- Hits        13496   12889   -607     
- Misses       1167    1774   +607     

@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2021

@codecov[bot] is not allowed to run commands

Hey, I reacted but my real name is @Mergifyio

@mergify mergify bot added the ready PRs ready to be merged label Aug 25, 2021
@carmocca carmocca enabled auto-merge (squash) August 25, 2021 12:12
@carmocca carmocca merged commit 5ff89a7 into master Aug 25, 2021
@carmocca carmocca deleted the ci/unskip-test branch August 25, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants