Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tpu cleaning job from CI #9272

Closed
wants to merge 1 commit into from

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Sep 2, 2021

What does this PR do?

The TPU Cleaning job is failing pretty consistently in CI causing our CI to be red. Is it okay to remove this job? Or do we want to fix it to make it work again?
Fixes #8961

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca
Copy link
Contributor

carmocca commented Sep 2, 2021

I think it's necessary, but the job runs every 20 minutes and fails from time to time.
I don't know what causes the failure, though.

cc: @Borda @kaushikb11

@Borda Borda added the ci Continuous Integration label Sep 2, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is our insurance against hacking TPU resources, we need to preserve it and fix it if needed :]

@daniellepintz
Copy link
Contributor Author

@Borda sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TPU tests failing in CI
4 participants