-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary TrainingEpochLoop
return
#9298
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9298 +/- ##
=======================================
Coverage 92% 93%
=======================================
Files 178 178
Lines 14855 15650 +795
=======================================
+ Hits 13704 14482 +778
- Misses 1151 1168 +17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we are covering the edge case, hope we don't miss another one 🙈
What does this PR do?
We were returning the
training_epoch_end
input as the output ofTrainingEpochLoop
, I believe this is legacy and no longer necessary. Let's see what CI thinksDoes your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review