Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary TrainingEpochLoop return #9298

Merged
merged 5 commits into from
Sep 6, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 3, 2021

What does this PR do?

We were returning the training_epoch_end input as the output of TrainingEpochLoop, I believe this is legacy and no longer necessary. Let's see what CI thinks

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.5 milestone Sep 3, 2021
@carmocca carmocca self-assigned this Sep 3, 2021
@carmocca carmocca mentioned this pull request Sep 3, 2021
13 tasks
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #9298 (9a15f78) into master (b91747e) will increase coverage by 0%.
The diff coverage is 93%.

@@           Coverage Diff           @@
##           master   #9298    +/-   ##
=======================================
  Coverage      92%     93%            
=======================================
  Files         178     178            
  Lines       14855   15650   +795     
=======================================
+ Hits        13704   14482   +778     
- Misses       1151    1168    +17     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we are covering the edge case, hope we don't miss another one 🙈

tests/trainer/test_dataloaders.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Sep 3, 2021
@carmocca carmocca enabled auto-merge (squash) September 4, 2021 00:07
@carmocca carmocca merged commit 05ff1b2 into master Sep 6, 2021
@carmocca carmocca deleted the refactor/epoc-loop-no-return branch September 6, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants