Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TPU cleaning job #9301

Merged
merged 3 commits into from
Sep 3, 2021
Merged

Fix TPU cleaning job #9301

merged 3 commits into from
Sep 3, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Sep 3, 2021

What does this PR do?

Fixes #8961

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda self-requested a review September 3, 2021 13:46
@kaushikb11 kaushikb11 marked this pull request as ready for review September 3, 2021 14:00
@mergify mergify bot added the ready PRs ready to be merged label Sep 3, 2021
@mergify mergify bot requested a review from a team September 3, 2021 14:21
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #9301 (d62fca7) into master (b91747e) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #9301   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         178     178           
  Lines       14855   14850    -5     
======================================
- Hits        13704   13701    -3     
+ Misses       1151    1149    -2     

@Borda Borda enabled auto-merge (squash) September 3, 2021 14:39
@Borda Borda merged commit 9d0caa6 into master Sep 3, 2021
@Borda Borda deleted the fix/tpu_cleaning branch September 3, 2021 15:13
justusschock pushed a commit that referenced this pull request Sep 7, 2021
justusschock pushed a commit that referenced this pull request Sep 7, 2021
awaelchli pushed a commit that referenced this pull request Sep 7, 2021
lexierule pushed a commit that referenced this pull request Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TPU tests failing in CI
5 participants