Remove some incorrect comments in ddp.py #9319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wayi1
commented
Sep 4, 2021
wayi1
commented
- Post-localSGD should be available after 1.10 instead of 1.9
- The package is available on Windows.
1) Post-localSGD should be available after 1.10 instead of 1.9 2) The package is available on Windows.
wayi1
requested review from
awaelchli,
justusschock,
SeanNaren and
tchaton
as code owners
awaelchli
approved these changes
Sep 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #9319 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 178 178
Lines 14850 14850
=======================================
- Hits 13701 13090 -611
- Misses 1149 1760 +611 |
carmocca
approved these changes
Sep 6, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.