Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torch v1.11.0 to the list of versions in adjust_versions.py #9679

Merged
merged 4 commits into from
Sep 24, 2021

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Sep 24, 2021

What does this PR do?

Fixes a broken CI job, caused by new nightly version of Pytorch, v1.11

Fixes #9676

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #9679 (c9669ec) into master (568a1e0) will increase coverage by 0%.
The diff coverage is n/a.

❗ Current head c9669ec differs from pull request most recent head 01acada. Consider uploading reports for the commit 01acada to get more accurate results

@@          Coverage Diff           @@
##           master   #9679   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files         179     179           
  Lines       15329   15306   -23     
======================================
- Hits        13603   13583   -20     
+ Misses       1726    1723    -3     

@awaelchli awaelchli added the ci Continuous Integration label Sep 24, 2021
@mergify mergify bot added the ready PRs ready to be merged label Sep 24, 2021
@daniellepintz
Copy link
Contributor Author

We are seeing similar CI failures to #9676, now more widespread across CI build Docker jobs

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda
Copy link
Member

Borda commented Sep 24, 2021

@daniellepintz this is irrelevant since you drop these devel runs from CI :)
Btw, pls fill check boxes accordingly 🐰

Update: cheking the linked issues and maybe the problem is there

@daniellepintz daniellepintz merged commit c2e3ec1 into Lightning-AI:master Sep 24, 2021
@daniellepintz daniellepintz deleted the fix_ci branch September 24, 2021 08:27
@daniellepintz
Copy link
Contributor Author

Merging since there are similar failures on the last merged PR #9612

@awaelchli awaelchli added this to the v1.5 milestone Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 Docker CI jobs failing on master
5 participants