Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable validation completely when overfit_batches>0 #9709

Merged
merged 35 commits into from
Dec 1, 2021

Conversation

popfido
Copy link
Contributor

@popfido popfido commented Sep 26, 2021

What does this PR do?

Fixes #9989

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@popfido popfido changed the title [fix]bug that cause ineffective of no validation [fix]bug that cause ineffective of limit_val_batches=0.0 when overfit_batches>0 Sep 26, 2021
@popfido popfido changed the title [fix]bug that cause ineffective of limit_val_batches=0.0 when overfit_batches>0 [fix]bug that cause ineffectiveness of limit_val_batches=0.0 when overfit_batches>0 Sep 26, 2021
@popfido popfido changed the title [fix]bug that cause ineffectiveness of limit_val_batches=0.0 when overfit_batches>0 Fix bug that cause ineffectiveness of limit_val_batches=0.0 when overfit_batches>0 Sep 26, 2021
@awaelchli awaelchli added bug Something isn't working data handling Generic data-related topic labels Sep 26, 2021
@awaelchli awaelchli added this to the v1.4.x milestone Sep 26, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: thomas chaton <thomas@grid.ai>
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #9709 (346ede5) into master (ce0a977) will decrease coverage by 3%.
The diff coverage is 100%.

❗ Current head 346ede5 differs from pull request most recent head c741753. Consider uploading reports for the commit c741753 to get more accurate results

@@           Coverage Diff           @@
##           master   #9709    +/-   ##
=======================================
- Coverage      92%     89%    -3%     
=======================================
  Files         177     179     +2     
  Lines       16290   15813   -477     
=======================================
- Hits        14948   14035   -913     
- Misses       1342    1778   +436     

Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

tests/callbacks/test_early_stopping.py Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/trainer/trainer.py Show resolved Hide resolved
tests/trainer/test_trainer_tricks.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 25, 2021
pytorch_lightning/trainer/trainer.py Show resolved Hide resolved
tests/trainer/test_trainer_tricks.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@popfido
Copy link
Contributor Author

popfido commented Nov 26, 2021

@rohitgr7 One of the test cases on macos is still in timeout, other issues are resolved

@rohitgr7
Copy link
Contributor

@rohitgr7 One of the test cases on macos is still in timeout, other issues are resolved

@popfido don't worry about that.. happens sometimes.

@mergify mergify bot removed the has conflicts label Dec 1, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) December 1, 2021 13:04
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@kaushikb11 kaushikb11 merged commit 72cc8b7 into Lightning-AI:master Dec 1, 2021
@popfido popfido deleted the bugfix/8962 branch December 6, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data handling Generic data-related topic ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove validation completely when overfit_batches > 0
6 participants