-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable validation completely when overfit_batches>0
#9709
Conversation
limit_val_batches=0.0
when overfit_batches>0
for more information, see https://pre-commit.ci
limit_val_batches=0.0
when overfit_batches>0
limit_val_batches=0.0
when overfit_batches>0
limit_val_batches=0.0
when overfit_batches>0
limit_val_batches=0.0
when overfit_batches>0
Co-authored-by: thomas chaton <thomas@grid.ai>
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #9709 +/- ##
=======================================
- Coverage 92% 89% -3%
=======================================
Files 177 179 +2
Lines 16290 15813 -477
=======================================
- Hits 14948 14035 -913
- Misses 1342 1778 +436 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
@rohitgr7 One of the test cases on macos is still in timeout, other issues are resolved |
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
What does this PR do?
Fixes #9989
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃