Merge load functions #995
Merged
Merge load functions #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-03-03 01:35:43 UTC |
awaelchli
changed the title
awaelchli
changed the title
Borda
requested changes
Mar 2, 2020
* Use callable object for patching dataloaders * Add test for ddp with dataloaders passed to fit() * Update pytorch_lightning/trainer/trainer.py Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * Update pytorch_lightning/trainer/trainer.py Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
|
is this good? |
|
It is waiting for #946 @awaelchli right? |
|
no, for me it doesn't matter which one is merged first :) |
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>
Borda
requested changes
Mar 2, 2020
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
* Update README.md * Update README.md * Use callable object for patching dataloaders (Lightning-AI#971) * Use callable object for patching dataloaders * Add test for ddp with dataloaders passed to fit() * Update pytorch_lightning/trainer/trainer.py Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * Update pytorch_lightning/trainer/trainer.py Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * merge load functions * update tests * fix documentation warnings * fix line too long * fix line too long * print deprecation warning Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * move tags_csv argument to end of signature * fix typo, update version numbers * fix line too long * add typing as requested * update changelog Co-authored-by: William Falcon <waf2107@columbia.edu> Co-authored-by: Sho Arora <sho854@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Implements #994
Changes:
LightningModule.load_from_checkpoint.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃