Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate coco from map #2884

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Isalia20
Copy link
Contributor

@Isalia20 Isalia20 commented Dec 25, 2024

What does this PR do?

Part of the fix of #2877. This PR decouples the coco backend from the mAP metric. This is part of the fix of 2877 issue because for me to implement functional mAP I would have to duplicate a lot of code unless this class was created. This class will help to duplicate as little code as possible while implementing functional version of mAP. It also makes mAP less heavy with coco stuff and abstracts it away as a coco backend private instance

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

Did you have fun? yes

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2884.org.readthedocs.build/en/2884/

@Isalia20
Copy link
Contributor Author

Huh weird, I thought pre commit checks covered the mypy checks as well. Will fix them

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 99 lines in your changes missing coverage. Please review.

Project coverage is 69%. Comparing base (7bda8f7) to head (b89fe5f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2884   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         332     333    +1     
  Lines       18966   18984   +18     
======================================
+ Hits        13055   13103   +48     
+ Misses       5911    5881   -30     

@Isalia20 Isalia20 marked this pull request as ready for review December 25, 2024 21:25
@Isalia20
Copy link
Contributor Author

I'll wait to get some comments on this first and then proceed with functional part of mAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant