-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable more PL integrations #739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
=====================================
Coverage 94% 95%
=====================================
Files 171 171
Lines 6867 6875 +8
=====================================
+ Hits 6480 6507 +27
+ Misses 387 368 -19 |
Borda
requested review from
ananyahjha93,
ethanwharris,
justusschock,
SeanNaren,
SkafteNicki and
tchaton
as code owners
January 10, 2022 19:49
@SkafteNicki this looks strange, how it can pass list but does not have
|
ethanwharris
approved these changes
Jan 10, 2022
awaelchli
approved these changes
Jan 11, 2022
rohitgr7
reviewed
Jan 12, 2022
rohitgr7
reviewed
Jan 12, 2022
rohitgr7
approved these changes
Jan 12, 2022
Borda
force-pushed
the
ci/integrate-PL
branch
3 times, most recently
from
January 13, 2022 10:38
dc6a07f
to
6f1a1c4
Compare
for more information, see https://pre-commit.ci
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda
force-pushed
the
ci/integrate-PL
branch
from
January 13, 2022 23:31
d39e424
to
14db2c5
Compare
Borda
force-pushed
the
ci/integrate-PL
branch
from
January 14, 2022 08:25
375ca86
to
e260921
Compare
SkafteNicki
reviewed
Jan 14, 2022
for more information, see https://pre-commit.ci
…/metrics into ci/integrate-PL
for more information, see https://pre-commit.ci
SkafteNicki
approved these changes
Jan 14, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃