Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable more PL integrations #739

Merged
merged 25 commits into from
Jan 14, 2022
Merged

enable more PL integrations #739

merged 25 commits into from
Jan 14, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 10, 2022

What does this PR do?

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the test / CI testing or CI label Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #739 (c782d2d) into master (7595120) will increase coverage by 0%.
The diff coverage is 95%.

@@          Coverage Diff          @@
##           master   #739   +/-   ##
=====================================
  Coverage      94%    95%           
=====================================
  Files         171    171           
  Lines        6867   6875    +8     
=====================================
+ Hits         6480   6507   +27     
+ Misses        387    368   -19     

@Borda
Copy link
Member Author

Borda commented Jan 10, 2022

@SkafteNicki this looks strange, how it can pass list but does not have len()?

            if isinstance(value, list):
>               value = torch.tensor(value)
E               TypeError: object of type 'SumMetric' has no len()

integrations/test_lightning.py Outdated Show resolved Hide resolved
integrations/test_lightning.py Outdated Show resolved Hide resolved
@Borda Borda force-pushed the ci/integrate-PL branch 3 times, most recently from dc6a07f to 6f1a1c4 Compare January 13, 2022 10:38
@mergify mergify bot removed the ready label Jan 14, 2022
@Borda Borda enabled auto-merge (squash) January 14, 2022 10:57
@mergify mergify bot added the ready label Jan 14, 2022
@Borda Borda merged commit 07cca4d into master Jan 14, 2022
@Borda Borda deleted the ci/integrate-PL branch January 14, 2022 15:58
@carmocca carmocca added this to the v0.7 milestone Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants