Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds undeclared dependency on setuptools #155

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

groodt
Copy link
Contributor

@groodt groodt commented Aug 3, 2023

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

Fixes the undeclared dependency on setuptools. There is an undeclared dependency on setuptools here

While it is true that most python environments will have setuptools pre-installed, this is not always safe to assume.

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

@awaelchli
Copy link
Member

awaelchli commented Aug 3, 2023

We don't have this dep in lightning either, should it be there? @Borda and @carmocca know better about this than me :)

@Borda
Copy link
Member

Borda commented Aug 3, 2023

We don't have this dep in lightning either, should it be there? @Borda and @carmocca know better about this than me :)

@groodt Where is it used? I guess in setup.py ony, right?

@awaelchli awaelchli merged commit 0f15c9d into Lightning-AI:main Aug 3, 2023
30 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants