Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: debug pkg create on multi-OS #347

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: debug pkg create on multi-OS #347

wants to merge 1 commit into from

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 16, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

debugging strange issue with unzip created package on another OS?

Traceback (most recent call last):
  File "/home/runner/.local/bin/twine", line 8, in <module>
    sys.exit(main())
  File "/home/runner/.local/lib/python3.[10](https://github.com/Lightning-AI/utilities/actions/runs/12349525363/job/34460588681#step:3:11)/site-packages/twine/__main__.py", line 33, in main
    error = cli.dispatch(sys.argv[1:])
  File "/home/runner/.local/lib/python3.10/site-packages/twine/cli.py", line [12](https://github.com/Lightning-AI/utilities/actions/runs/12349525363/job/34460588681#step:3:13)9, in dispatch
    return main(args.args)
  File "/home/runner/.local/lib/python3.10/site-packages/twine/commands/check.py", line 195, in main
    return check(parsed_args.dists, strict=parsed_args.strict)
  File "/home/runner/.local/lib/python3.10/site-packages/twine/commands/check.py", line 141, in check
    warnings, is_ok = _check_file(filename, render_warning_stream)
  File "/home/runner/.local/lib/python3.10/site-packages/twine/commands/check.py", line 84, in _check_file
    package = package_file.PackageFile.from_filename(filename, comment=None)
  File "/home/runner/.local/lib/python3.10/site-packages/twine/package.py", line 124, in from_filename
    meta = DIST_TYPES[dtype](filename)
  File "/home/runner/.local/lib/python3.10/site-packages/twine/wheel.py", line 43, in __init__
    self.extractMetadata()
  File "/home/runner/.local/lib/python3.10/site-packages/pkginfo/distribution.py", line 168, in extractMetadata
    data = self.read()
  File "/home/runner/.local/lib/python3.10/site-packages/twine/wheel.py", line 65, in read
    archive = zipfile.ZipFile(fqn)
  File "/usr/lib/python3.10/zipfile.py", line 1272, in __init__
    self._RealGetContents()
  File "/usr/lib/python3.10/zipfile.py", line [13](https://github.com/Lightning-AI/utilities/actions/runs/12349525363/job/34460588681#step:3:14)69, in _RealGetContents
    raise BadZipFile("Bad magic number for central directory")
zipfile.BadZipFile: Bad magic number for central directory
Checking dist/lightning_utilities-0.12.0.dev0-py3-none-any.whl

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.


📚 Documentation preview 📚: https://lit-utilities--347.org.readthedocs.build/en/347/

@github-actions github-actions bot added ci/cd Continuous integration and delivery package labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous integration and delivery package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant