Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add core members #349

Merged
merged 6 commits into from
Nov 9, 2020
Merged

add core members #349

merged 6 commits into from
Nov 9, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 9, 2020

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 9, 2020
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #349 (7e8a1b9) into master (6895350) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   82.34%   82.37%   +0.02%     
==========================================
  Files         100      100              
  Lines        5620     5612       -8     
==========================================
- Hits         4628     4623       -5     
+ Misses        992      989       -3     
Flag Coverage Δ
cpu 24.67% <67.50%> (-0.09%) ⬇️
pytest 24.67% <67.50%> (-0.09%) ⬇️
unittests 81.62% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/datasets/__init__.py 100.00% <ø> (ø)
pl_bolts/models/self_supervised/amdim/__init__.py 80.00% <ø> (ø)
pl_bolts/models/self_supervised/amdim/datasets.py 61.11% <ø> (ø)
..._bolts/models/self_supervised/cpc/cpc_finetuner.py 100.00% <ø> (ø)
pl_bolts/models/self_supervised/cpc/cpc_module.py 20.31% <ø> (ø)
pl_bolts/models/self_supervised/moco/__init__.py 100.00% <ø> (ø)
pl_bolts/models/self_supervised/moco/transforms.py 100.00% <ø> (ø)
.../models/self_supervised/simclr/simclr_finetuner.py 100.00% <ø> (ø)
pl_bolts/models/self_supervised/swav/__init__.py 100.00% <ø> (ø)
pl_bolts/__init__.py 100.00% <100.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6895350...7e8a1b9. Read the comment docs.

akihironitta and others added 2 commits November 9, 2020 18:32
* Create branch ci/add-import-checker

* Add isort to ci

* Add pyproject.toml

* Apply isort

* Update pyproject.toml

* Add isort to requirements/test.txt

* Add pre-commit to requirements/test.txt

* Add isort hook from the official repo

* Update isort pre-commit config

* Split flake8 and isort checks

* suggestion-name

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@Borda Borda marked this pull request as ready for review November 9, 2020 17:50
@ananyahjha93 ananyahjha93 merged commit 6674ece into master Nov 9, 2020
@ananyahjha93 ananyahjha93 deleted the docs/add-core branch November 9, 2020 18:40
@Borda Borda added this to the v0.3 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants