Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reference to torch._six #993

Merged
merged 8 commits into from
Mar 28, 2023

Conversation

cdeepali
Copy link
Contributor

@cdeepali cdeepali commented Mar 17, 2023

What does this PR do?

Removes reference to torch._six as it has been removed in PyTorch 2.0 Reference - pytorch/pytorch#94709

Fixes #992

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the datamodule Anything related to datamodules label Mar 17, 2023
@kunimatsu-tri
Copy link

Hi, can I ask the timeline for this to be merged? Since this is blocking everyone from upgrading the PyTorch version to v2.0.0, I'd like you guys to merge this as soon as possible.

@Borda Borda changed the title remove reference to torch._six remove reference to torch._six Mar 28, 2023
@Borda Borda merged commit c4e717c into Lightning-Universe:master Mar 28, 2023
@kunimatsu-tri
Copy link

Thank you for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodule Anything related to datamodules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No module named 'torch._six'
3 participants