Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Onboard segmentation inputs to new object #1015

Merged
merged 9 commits into from
Dec 1, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Dec 1, 2021

What does this PR do?

Fixes #961

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris marked this pull request as ready for review December 1, 2021 18:59
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #1015 (6a8972e) into master (e363aa8) will increase coverage by 2.07%.
The diff coverage is 92.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
+ Coverage   82.11%   84.18%   +2.07%     
==========================================
  Files         254      254              
  Lines       13590    13591       +1     
==========================================
+ Hits        11159    11442     +283     
+ Misses       2431     2149     -282     
Flag Coverage Δ
unittests 84.18% <92.37%> (+2.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/classification/data.py 95.62% <ø> (+13.66%) ⬆️
flash/image/data.py 93.33% <60.00%> (+18.68%) ⬆️
flash/image/segmentation/data.py 91.91% <93.00%> (+11.33%) ⬆️
flash/core/data/data_module.py 93.28% <100.00%> (+0.37%) ⬆️
flash/core/data/utilities/paths.py 91.52% <100.00%> (+7.88%) ⬆️
flash/image/segmentation/model.py 91.89% <100.00%> (+16.21%) ⬆️
flash/image/segmentation/output.py 76.81% <100.00%> (+7.69%) ⬆️
flash/text/question_answering/model.py 28.27% <0.00%> (-62.76%) ⬇️
flash/text/question_answering/data.py 28.16% <0.00%> (-58.87%) ⬇️
flash/text/classification/cli.py 53.84% <0.00%> (-46.16%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e363aa8...6a8972e. Read the comment docs.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ethanwharris ethanwharris merged commit 78c60ed into master Dec 1, 2021
@ethanwharris ethanwharris deleted the feature/segmentation_inputs branch December 1, 2021 21:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboard image inputs to new Input object
2 participants