Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix object detection / keypoint detection / instance segmentation #1072

Merged
merged 9 commits into from
Dec 14, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Dec 14, 2021

What does this PR do?

Makes the following changes:

  • fixes the examples
  • adds the examples to the ci
  • fixes a bug where transforms where not being called

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added bug / fix Something isn't working documentation Improvements or additions to documentation labels Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@924aee8). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 791db69 differs from pull request most recent head 8b8b0b0. Consider uploading reports for the commit 8b8b0b0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1072   +/-   ##
=========================================
  Coverage          ?   87.61%           
=========================================
  Files             ?      281           
  Lines             ?    12790           
  Branches          ?        0           
=========================================
  Hits              ?    11206           
  Misses            ?     1584           
  Partials          ?        0           
Flag Coverage Δ
unittests 87.61% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/data_module.py 94.89% <100.00%> (ø)
flash/core/data/io/input_transform.py 73.86% <100.00%> (ø)
flash/image/detection/data.py 94.23% <100.00%> (ø)
flash/image/instance_segmentation/data.py 95.45% <100.00%> (ø)
flash/image/keypoint_detection/data.py 94.28% <100.00%> (ø)
flash/image/keypoint_detection/input_transform.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 924aee8...8b8b0b0. Read the comment docs.

@ethanwharris ethanwharris changed the title Fix object detection / keypoint detection / instance segmentation examples and add to CI Fix object detection / keypoint detection / instance segmentation Dec 14, 2021
@ethanwharris ethanwharris enabled auto-merge (squash) December 14, 2021 22:31
@ethanwharris ethanwharris merged commit ba72af6 into master Dec 14, 2021
@ethanwharris ethanwharris deleted the bugfix/instance_segmentation_example branch December 14, 2021 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants