This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flozi00
requested review from
ananyahjha93,
Borda,
carmocca,
ethanwharris,
justusschock,
kaushikb11 and
tchaton
as code owners
December 15, 2021 11:55
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #1075 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 281 281
Lines 12804 12804
=======================================
Hits 11220 11220
Misses 1584 1584
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ethanwharris
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Mind also updating the CHANGELOG?
justusschock
approved these changes
Dec 15, 2021
I am not sure what to do with the failing macos test, any advice ? |
@flozi00 Just a flaky test, no need to worry about it. Will merge your PR now 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces the static wav2vec2 processor with the autoprocessor class.
Furthermore it's now possible to train pretrained only model without pretrained processor by defining the processor seperately.
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃