Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

speech recognition auto processor #1075

Merged
merged 7 commits into from
Dec 15, 2021
Merged

speech recognition auto processor #1075

merged 7 commits into from
Dec 15, 2021

Conversation

flozi00
Copy link
Contributor

@flozi00 flozi00 commented Dec 15, 2021

What does this PR do?

This PR replaces the static wav2vec2 processor with the autoprocessor class.
Furthermore it's now possible to train pretrained only model without pretrained processor by defining the processor seperately.

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #1075 (e98b7fb) into master (6f3dc08) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1075   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files         281      281           
  Lines       12804    12804           
=======================================
  Hits        11220    11220           
  Misses       1584     1584           
Flag Coverage Δ
unittests 87.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/speech_recognition/model.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3dc08...e98b7fb. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Mind also updating the CHANGELOG?

@ethanwharris ethanwharris added the enhancement New feature or request label Dec 15, 2021
@ethanwharris ethanwharris enabled auto-merge (squash) December 15, 2021 13:18
@flozi00
Copy link
Contributor Author

flozi00 commented Dec 15, 2021

I am not sure what to do with the failing macos test, any advice ?

@ethanwharris
Copy link
Collaborator

@flozi00 Just a flaky test, no need to worry about it. Will merge your PR now 😃

@ethanwharris ethanwharris merged commit ebd93e3 into Lightning-Universe:master Dec 15, 2021
@flozi00 flozi00 deleted the patch-1 branch December 15, 2021 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants