Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add support for segmentation with different mask extensions #1130

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes #1129

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #1130 (f673ec0) into master (4997226) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1130      +/-   ##
==========================================
- Coverage   88.84%   88.84%   -0.01%     
==========================================
  Files         286      286              
  Lines       12931    12927       -4     
==========================================
- Hits        11489    11485       -4     
  Misses       1442     1442              
Flag Coverage Δ
unittests 88.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/segmentation/data.py 100.00% <ø> (ø)
flash/image/segmentation/input.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4997226...f673ec0. Read the comment docs.

@ethanwharris ethanwharris added the enhancement New feature or request label Jan 19, 2022
Copy link

@AlexandreBrown AlexandreBrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes and it works.
LGTM

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat, tiny comments !

flash/image/segmentation/input.py Outdated Show resolved Hide resolved
flash/image/segmentation/input.py Show resolved Hide resolved
@ethanwharris ethanwharris merged commit 8b244d7 into master Jan 20, 2022
@ethanwharris ethanwharris deleted the feature/segmentation_mask_extensions branch January 20, 2022 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support targets file names with different file extension than x file names
3 participants