Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add ability to override the TargetFormatter in classification tasks #1171

Merged
merged 10 commits into from
Feb 15, 2022

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Feb 15, 2022

What does this PR do?

Fixes #1131

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #1171 (8cc1bc4) into master (4c62482) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1171      +/-   ##
==========================================
+ Coverage   90.87%   90.88%   +0.01%     
==========================================
  Files         286      286              
  Lines       12758    12766       +8     
==========================================
+ Hits        11594    11603       +9     
+ Misses       1164     1163       -1     
Flag Coverage Δ
unittests 90.88% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/data_module.py 94.09% <ø> (ø)
flash/audio/classification/data.py 100.00% <100.00%> (ø)
flash/core/data/utilities/classification.py 98.24% <100.00%> (+0.02%) ⬆️
flash/image/classification/data.py 97.90% <100.00%> (+0.01%) ⬆️
flash/image/detection/data.py 100.00% <100.00%> (ø)
flash/tabular/classification/data.py 96.42% <100.00%> (+0.13%) ⬆️
flash/text/classification/data.py 100.00% <100.00%> (ø)
flash/video/classification/data.py 100.00% <100.00%> (ø)
flash/text/question_answering/model.py 92.71% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c62482...8cc1bc4. Read the comment docs.

@ethanwharris ethanwharris merged commit 1b1b939 into master Feb 15, 2022
@ethanwharris ethanwharris deleted the feature/override_target_formatter branch February 15, 2022 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to pass the TargetFormatter to use with classification data modules
1 participant