Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix loss function buffer support #1203

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Mar 1, 2022

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the bug / fix Something isn't working label Mar 1, 2022
@ethanwharris ethanwharris added this to the 0.7.x milestone Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #1203 (3bf6ad0) into master (3c06c3f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1203      +/-   ##
==========================================
+ Coverage   90.95%   90.96%   +0.01%     
==========================================
  Files         284      284              
  Lines       12686    12689       +3     
==========================================
+ Hits        11539    11543       +4     
+ Misses       1147     1146       -1     
Flag Coverage Δ
unittests 90.96% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/utilities/apply_func.py 94.11% <100.00%> (+1.26%) ⬆️
flash/text/question_answering/model.py 92.56% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c06c3f...3bf6ad0. Read the comment docs.

Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉 LGTM, thanks @ethanwharris

@krshrimali krshrimali enabled auto-merge (squash) March 1, 2022 11:30
@krshrimali krshrimali merged commit c72df0d into master Mar 1, 2022
@krshrimali krshrimali deleted the bugfix/loss_fn_parameters branch March 1, 2022 11:43
ethanwharris added a commit that referenced this pull request Mar 1, 2022
* Fix loss function buffer support

* Update CHANGELOG.md
ethanwharris added a commit that referenced this pull request Mar 1, 2022
* Fix loss function buffer support

* Update CHANGELOG.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants