This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 212
Skip core tests when not core
testing
#1330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwharris
requested review from
Borda,
tchaton,
justusschock,
carmocca and
kaushikb11
as code owners
May 5, 2022 18:27
Codecov Report
@@ Coverage Diff @@
## master #1330 +/- ##
==========================================
+ Coverage 81.65% 91.48% +9.82%
==========================================
Files 287 287
Lines 12846 12881 +35
==========================================
+ Hits 10490 11784 +1294
+ Misses 2356 1097 -1259
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ethanwharris
changed the title
[WIP] Skip core tests when not
Skip core tests when not May 5, 2022
core
testingcore
testing
krshrimali
approved these changes
May 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀 LGTM 😃
ethanwharris
added a commit
that referenced
this pull request
May 11, 2022
ethanwharris
added a commit
that referenced
this pull request
May 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, all CI workflows run all of the tests that do not have specific requirements ('core' tests).
WIth this PR, the core tests will only run in core workflows, speeding up the CI and reducing issues created by test flakiness.
This PR additionally filters some serve tests into their own workflow too.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃