Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

CI: Update docker image #1411

Merged
merged 3 commits into from
Aug 16, 2022
Merged

CI: Update docker image #1411

merged 3 commits into from
Aug 16, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Aug 5, 2022

What does this PR do?

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes?
  • [n/a] Did you write any new necessary tests? [not needed for typos/docs]
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta changed the title Update docker images CI: Update docker images Aug 5, 2022
@akihironitta akihironitta changed the title CI: Update docker images CI: Update docker image Aug 5, 2022
@akihironitta akihironitta added the tests / CI Tests and continuous integration label Aug 5, 2022
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #1411 (e7561a7) into master (2657315) will decrease coverage by 0.79%.
The diff coverage is n/a.

❗ Current head e7561a7 differs from pull request most recent head e59188d. Consider uploading reports for the commit e59188d to get more accurate results

@@            Coverage Diff             @@
##           master    #1411      +/-   ##
==========================================
- Coverage   91.79%   91.00%   -0.80%     
==========================================
  Files         286      286              
  Lines       12861    12861              
==========================================
- Hits        11806    11704     -102     
- Misses       1055     1157     +102     
Flag Coverage Δ
unittests 91.00% <ø> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/graph/classification/input.py 45.45% <0.00%> (-54.55%) ⬇️
flash/graph/classification/cli.py 38.46% <0.00%> (-53.85%) ⬇️
flash/graph/collate.py 50.00% <0.00%> (-50.00%) ⬇️
flash/graph/classification/model.py 42.62% <0.00%> (-49.19%) ⬇️
flash/graph/embedding/model.py 54.83% <0.00%> (-45.17%) ⬇️
flash/graph/backbones.py 64.28% <0.00%> (-35.72%) ⬇️
flash/graph/classification/input_transform.py 66.66% <0.00%> (-33.34%) ⬇️
flash/graph/classification/data.py 69.23% <0.00%> (-30.77%) ⬇️
flash/core/data/utilities/samples.py 87.50% <0.00%> (-12.50%) ⬇️
flash/text/question_answering/collate.py 95.29% <0.00%> (-4.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@krshrimali
Copy link
Contributor

Please don't worry about the failures, the CI is failing, and I'm working on it: #1410. :)

@krshrimali krshrimali self-assigned this Aug 8, 2022
@krshrimali krshrimali added this to the 0.8.0 milestone Aug 8, 2022
@krshrimali
Copy link
Contributor

A couple of examples failures, namely: Lightning-AI.lightning-flash (Examples) (domain text with GPUs 0) and Lightning-AI.lightning-flash (Examples) (domain video with GPUs 0,1) are flaky. The text example is failing with some connection error to HuggingFace.co and the video example is failing with CUDA Runtime Error, I'll be re-running these tests to ensure they pass, and then we can merge this. (Other failures are being fixed, should be good very soon)

@akihironitta
Copy link
Contributor Author

@krshrimali Thank you, Kush, for having a look at this! I'll re-re-run these three failing jobs and see if they pass this time :)

Lightning-AI.lightning-flash (Examples) Required
Lightning-AI.lightning-flash (Examples) (domain video with GPUs 0,1)
Lightning-AI.lightning-flash (Special)

@ethanwharris ethanwharris merged commit e95561a into master Aug 16, 2022
@ethanwharris ethanwharris deleted the ci/update-docker-image branch August 16, 2022 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests / CI Tests and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants